Feature request: Unknown design resolution of the Page
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 7.8k
- Forks
- 1.2k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 49
Description
Is your feature request related to a problem? Please describe.
If I'm not mistaken the UI Component and Page resolutions have to be the same for the proper custom UI scaling otherwise we have no idea for which resolution the UI elements were designed for and thus we have to remember to always align these resolutions to implement proper UI scaling.
Describe the solution you'd like
Extending UIPage class with DesignResolution property and injecting Design.Resolution from the asset parameters seems to work.
Describe alternatives you've considered
Either keeping the same UI Component and Page resolution or forwarding design resolution via property of the script allows proper UI elements custom scaling.
Additional context
The solution turned out to be rather simple and I have already made it work on my branch. Here's the commit.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the UIPage class and the asset parameters referenced in the issue, then review the linked commit for the proposed Design.Resolution flow. The change is complete when UIPage exposes the design resolution needed for custom UI scaling without requiring component and page resolutions to match.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100