RadiancePrefilteringGGXNoComputeEffect being unrolled in 4.2.2381
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 7.8k
- Forks
- 1.2k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 49
Description
Release Type: Official Release
Version: 4.2.2381
Platform(s): Windows
Describe the bug
Since updating a base project from 4.2.2293 there has been a new warning about a shader seeming to not do anything and being forced to unroll. There doesnt seem to be any effects that I have noticed so Im unsure of the consequence of this but it is new so I wanted to log it.
To Reproduce
Steps to reproduce the behavior:
- create a new project with Stride 4.2.2293
- build and see no warning
- update the packages to 4.2.2381
- build and see the warning
Log and callstacks
2>EXEC : warning 2.911s: [AssetCompiler] C:\Users\User\.nuget\packages\stride.core.assets.compilerapp\4.2.0.2381\lib\net8.0-windows7.0\log\shader_RadiancePrefilteringGGXNoComputeEffect_3b42dc19fe144f55e87a1c10c0c53a3f.hlsl(212,5-48): warning X3557: loop doesn't seem to do anything, forcing loop to unroll
2>
2>EXEC : warning 2.912s: [AssetCompiler] C:\Users\User\.nuget\packages\stride.core.assets.compilerapp\4.2.0.2381\lib\net8.0-windows7.0\log\shader_RadiancePrefilteringGGXNoComputeEffect_3b42dc19fe144f55e87a1c10c0c53a3f.hlsl(212,5-48): warning X3557: loop doesn't seem to do anything, forcing loop to unroll
2>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the generated shader log at shader_RadiancePrefilteringGGXNoComputeEffect_3b42dc19fe144f55e87a1c10c0c53a3f.hlsl, especially line 212, and compare builds from 4.2.2293 and 4.2.2381. Trace that generated shader back to its source and determine whether the X3557 warning changes rendering behavior; the issue is done when the warning's cause and consequence are established and the regression is addressed.
Written by the indexing model from the issue text.
Assessment
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100