InstancingComponent: InstancingUserArray does work when using object initializer syntax
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 7.8k
- Forks
- 1.2k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 49
Description
Release Type: Official Release
Version: 4.1.0.1948
Platform(s): Windows
Describe the bug
When using object initializer syntax or just setting the Matrices property the instances are not displayed.
To Reproduce
Steps to reproduce the behavior:
- Create an entity
- Add a ModelComponent
- Add a InstancingComponent and use the object initializer to set it up
- OR Use the setter of Matrices to update them
Expected behavior
The instances are displayed/updated correctly
Additional context
Imho the setter of matrices should either be private or we could just call the UpdateMatrices method from the setter (prefferred)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with InstancingComponent and trace how object initializer assignment and the Matrices setter differ from the normal update path. Reproduce both reported cases, then verify that instances are displayed and updated correctly after the fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100