stride3d / stride3d/stride

[Shader] Changes to shader in GameStudio are not always properly reloaded

Open
#1,255 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-GameStudio area-Graphics area-Shaders bug
Dominant language
C#
Stars
7.8k
Forks
1.2k
Avg merge
2d 17h
Merged PRs (30d)
49

Description

Release Type: Master

Version: Latest

Platform(s): GameStudio

Describe the bug
Changes to shader file might not be properly loaded in engine and instead will blink as if it was waiting for compilation but just reloads the previous version instead of the newest.

To Reproduce
See description, I didn't find a 100% consistent way to reproduce it.

Looks like the directory watcher issues multiple change notification for a single file save ...? This might be a weird race condition caused by those multiple notifications ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the GameStudio shader reload flow and the directory watcher handling shader file changes. Try to reproduce the intermittent reload with repeated saves, then trace whether multiple change notifications race with compilation or reload. Done means the newest shader version is consistently loaded rather than the previous version.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.