Nil is handled poorly

Open
#503 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
testing-qa

Research direction

Start by reading the assert.Nil implementation and its existing tests, then compare its behavior with the value == nil expectation and the linked nil_test.go example. Confirm the intended treatment of typed nil pointers and add or update focused tests so the resulting behavior is explicit.

Written by the indexing model from the issue text.

Description

revisit

assert.Nil passes on a value of (*int)(nil), I believe the function digs too deep on the value. It seems that assert.Nil should do the equivalent of value == nil, but instead the decision is deferred to reflect.Value.IsNil.

https://github.com/anacrolix/wat/blob/master/nil_test.go#L16 is an example of the unexpected behaviour.

Dominant language
Go
Stars
26.2k
Forks
1.9k
Avg merge
2d 4h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stretchr/testify

All issues in stretchr/testify

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.