Support order assertions on `sort.Interface` types

Open
#1,122 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
testing

Research direction

Start by reading Go's sort.Interface documentation and the existing assertion entry points around assert.IsIncreasing. Determine how the requested assertion should accept a sort.Interface implementation, then add coverage for the segments example and verify that increasing and non-increasing inputs produce the expected results.

Written by the indexing model from the issue text.

Description

Given the following type implementing the sort interface

type segment struct {
    left int
    right int
}

type segments []segment

func (l *segments) Len() int {
	return len([]segment(*l))
}

func (l *segments) Less(i, j int) bool {
	data := []segment(*l)
	return data[i].left < data[j].left  || (data[i].left == data[j].left && data[i].right < data[j].right)
}

func (l *segments) Swap(i, j int) {
	data := []segment(*l)
	data[i], data[j] = data[j], data[i]
}

I should be able to perform sort assertions

sample := segments([]segment{
{1, 2},
{3, 4},
})
assert.IsIncreasing(t, &sample)
Dominant language
Go
Stars
26.2k
Forks
1.9k
Avg merge
2d 4h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stretchr/testify

All issues in stretchr/testify

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.