Feature: Add button to video player that allows the user to search & add subtitles to the current Video

Open
#1,002 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript

Research direction

Start by reviewing the existing dul/feature/subtitle-search branch and the current video player, subtitle, settings, and movie or episode management entry points. Break the proposal into a scoped plan covering subtitle search, local storage, suggestions, administrator approval, merging, and the global setting; the work is done only when the agreed subset is implemented and verified across those flows.

Written by the indexing model from the issue text.

Description

Issue description

It would be a great feature to be able to add subtitles to a video on-the-fly for viewers. Of course, we want to prevent that a user downloads 50+ subtitles and that all of these also show up for every other viewer. Instead I suggest that the current viewer can download as many as he likes, and they get added into the browsers localstorage or local browser DB, but the viewer can then mark any of these local subtitles as "suggested". I would like to prevent the user from being able to just upload straight to our servers .. but maybe these suggestions could be viewed in the admin-interface alongside a video and the content-manager can then click on a button "add subtitle" which would auto-download from the API and append to the video, including a proper language label.
So the following things would have to be done to complete this task:

  • add API for opensubtitles or similar, allow admin to add login-credentials in the settings page
  • add "search for subtitle" button the video player, maybe in the subtitle dropdown
  • add a popup for subtitle searching, with a string input for your query, a checkbox for comparing the video hash (if this even works?) and a language filter, and of course a "download & use" button or similar for the individual search results
  • visually distinguish the "local" subtitles from the official streama subtitles, maybe with a little tag-like label next to the subtitle name
  • load subtitle data into localstorage or browser-DB
  • add button "suggest as official subtitle" which creates a subtitle-suggestion with all the required data for content-managers
  • show subtitle-suggestions in the movie & episode management area
  • add feature to download & add subtitle suggestions as content-managers
  • for users that suggested subtitles that were later applied by content-managers, prevent that this subtitle shows up twice. so add some sort of merging-logic
  • add new Checkbox in the settings page to globally add or remove this entire feature

Examples from VLC

image

Existing Branch

FYI, there is an existing branch where i started on this already. Not sure how much of this is usable:
https://github.com/streamaserver/streama/tree/dul/feature/subtitle-search

image

image

image

Dominant language
JavaScript
Stars
9.8k
Forks
978
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from streamaserver/streama

All issues in streamaserver/streama

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.