Invalid port versioncontrol service

Open
#98 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
docker-compose, go
Domain
devops

Research direction

Start with the storj-up init entry point and trace how recipes that add versioncontrol generate docker-compose.yaml. Reproduce the issue with a versioncontrol recipe and verify that the generated STORJ_ADDRESS uses a valid port instead of -1.

Written by the indexing model from the issue text.

Description

bug

Reason / Why?

storj-up v1.2.7 assigns an invalid port to the versioncontrol service.

When storj-up init versioncontrol or any other recipe that adds the versioncontrol service to the docker-compose.yaml file is executed it produces the following

version: "3.4"
services:
  versioncontrol:
    command:
    - versioncontrol
    - run
    deploy:
      replicas: 1
    environment:
      BINARY_GATEWAY_ROLLOUT_SEED: "0000000000000000000000000000000000000000000000000000000000000001"
      BINARY_IDENTITY_ROLLOUT_SEED: "0000000000000000000000000000000000000000000000000000000000000001"
      BINARY_SATELLITE_ROLLOUT_SEED: "0000000000000000000000000000000000000000000000000000000000000001"
      BINARY_STORAGENODE_ROLLOUT_SEED: "0000000000000000000000000000000000000000000000000000000000000001"
      BINARY_STORAGENODE_UPDATER_ROLLOUT_SEED: "0000000000000000000000000000000000000000000000000000000000000001"
      BINARY_UPLINK_ROLLOUT_SEED: "0000000000000000000000000000000000000000000000000000000000000001"
      STORJ_ADDRESS: 0.0.0.0:-1
      STORJ_DEBUG_ADDR: 0.0.0.0:11111
      STORJ_DEFAULTS: dev
      STORJ_LOG_LEVEL: debug
      STORJ_METRICS_APP_SUFFIX: sim
    image: img.dev.storj.io/storjup/storj:1.104.5
networks: {}

The environment variable STORJ_ADDRESS: 0.0.0.0:-1 has the -1 port, an invalid port.

What needs to be done?

Fix the versioncontrol service docker-compose generation to assign a valid port.

Acceptance criteria

  • Fix storj-up init with any recipe that adds the versioncontrol service into the docker-compose.yaml file to assign a valid port to the STORJ_ADDRESS environment variable.
Dominant language
Go
Stars
28
Forks
8
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from storj/up

All issues in storj/up

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.