Some tasks are being skipped (pagination needed for +100 pr comments)

Open
#19 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
github, javascript
Domain
api, backend

Research direction

Start by reproducing the skipped task counts with GitHub pull request 1301 and compare the discussion comments with the comments included in the app's summary. Investigate pagination for pull requests with more than 100 comments; done means all task checkboxes in the pull request affect the summary count consistently.

Written by the indexing model from the issue text.

Description

enhancement

I have been using this app for about 8 months now and it has been working great – thank you!

Today, for the first time, I noticed that it is skipping (not counting) some tasks in one of our PRs: https://github.com/ESCOMP/CTSM/pull/1301. Two check boxes that seem to be skipped are the ones in https://github.com/ESCOMP/CTSM/pull/1301#discussion_r614995519 and https://github.com/ESCOMP/CTSM/pull/1301#discussion_r614998877 – checking and unchecking those has no effect on the summary count, even though others in the PR (like https://github.com/ESCOMP/CTSM/pull/1301#pullrequestreview-630252567) are counted. There seem to be a few others in the PR that also aren't counted.

I can't tell what's going on here: I tried making a new PR in a test repo to reproduce this problem and wasn't able to.

This isn't critical for me, since I tend to double-check the final count with my own tool (https://github.com/ESMCI/github-tools), so feel free to close as a wontfix if you also can't reproduce it – but I wanted to raise this in case it's a more general issue.

Dominant language
JavaScript
Stars
151
Forks
45
Avg merge
10h 18m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.