bug: `goto()` and `waitForChanges()` can return before all components hydrate
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- playwright, typescript
- Domain
- testing-qa
Research direction
Start by checking out the waitForChanges-nested-sb branch from the reproduction repository, then run npm install, npm run build, and npm run test. Compare the "label with nested component over default network" and "label with nested component over slow network" cases. Done means goto() and waitForChanges() wait for nested third-party Stencil components so the slow-network case passes.
Written by the indexing model from the issue text.
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Stencil Playwright Version
0.2.1
Current Behavior
Given enough network latency and a 3rd-party Stencil component nested inside a local component, the Page.goto() and/or Page.waitForChanges() methods can return before the 3rd-party Stencil component finishes hydrating.
Expected Behavior
Nested, 3rd-party components are included in the goto() and waitForChanges() waiting.
Steps to Reproduce
- Checkout the repo and switch to the
@stencil/playwright/waitForChanges-nested-sbbranch, if needed. - Run
npm install - Run
npm run build - Run
npx playwright install, if needed - Run
npm run test - See the
"label with nested component over default network"passes while the"label with nested component over slow network"fails
Code Reproduction URL
http://github.com/nwhittaker/stencil-component/tree/%40stencil/playwright/waitForChanges-nested-sb
Additional Information
No response
- Dominant language
- TypeScript
- Stars
- 7
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from stenciljs/playwright
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
stenciljs/playwright#58 · 1 comment ·
-
stenciljs/playwright#56 · 2 comments · 1 reaction · 1 assignee ·
-
triage
Difficulty 4/5 3-5 days Newbie friendliness 35/100
stenciljs/playwright#43 ·
-
triage
Difficulty 4/5 3-5 days Newbie friendliness 35/100
stenciljs/playwright#42 ·
All issues in stenciljs/playwright
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·