feat(DockerBuilder): make ADD and COPY behaviour consistent with Docker

Open
#32 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
docker, typescript
Domain
build-system, devops

Research direction

Start at src/DockerBuilder.ts around line 167 and compare the existing ADD and COPY handling with Docker's ADD and COPY documentation. Determine which behavior is inconsistent, then verify the change against Dockerfile examples; done means ADD and COPY behave consistently where the dockter section supports both.

Written by the indexing model from the issue text.

Description

enhancement

We support both ADD and COPY in the # dockter section of a Dockerfile

https://github.com/stencila/dockter/blob/v0.2.6/src/DockerBuilder.ts#L167

Docker's ADD and COPY instructions are very similar but COPY is generally recommended. Nonetheless, if we support ADD in the # dockter section of a Dockerfile then we should provide consistent behaviour.

Dominant language
TypeScript
Stars
124
Forks
10
Avg merge
3h 28m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stencila/dockta

All issues in stencila/dockta

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.