Remove Asset Code Types 4 and 12
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- api, backend-api-design
Research direction
Review the existing asset code type definitions and the XDR compatibility implications described in the issue. Determine whether both tags can accept up to 12 bytes without violating compatibility expectations, and confirm that the protocol semantics and migration decision are agreed before implementation.
Written by the indexing model from the issue text.
Description
The two existing current non-native Asset Code types are currently guaranteed to be non-overlapping without the enum tag by length.
Given that there are no functional differences between asset code types, I propose deprecating the distinction between the types by allowing either tag to refer to up to 12 bytes of asset code.
This should simplify the handling of this both internally (and help ensure that treatment of asset types is uniform) and externally for consumers of the API.
This should be forwards compatible as old clients should produce XDR which is binary compatible with the new semantics, but may break backwards compatibility as new clients may produce XDR which is incompatible with old clients parsings. While breaking backwards compatibility is not great, it may be a worthwhile cleanup to remove this distinction.
The motivation for such a change is that stellar core's rules should not be enforcing UX-layer invariants.
- Dominant language
- RPC
- Stars
- 632
- Forks
- 399
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from stellar/stellar-protocol
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
stellar/stellar-protocol#2010 ·
-
stale
Difficulty 5/5 Over a week Newbie friendliness 42/100
stellar/stellar-protocol#1928 · 6 comments ·
-
needs draft SEP
stellar/stellar-protocol#773 · 12 comments · 1 assignee ·
-
CAP help wanted needs draft
Difficulty 5/5 Over a week Newbie friendliness 35/100
stellar/stellar-protocol#324 · 11 comments ·
-
help wanted needs draft SEP
Difficulty 5/5 Over a week Newbie friendliness 25/100
stellar/stellar-protocol#316 · 4 comments ·
All issues in stellar/stellar-protocol
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getgrav/grav-plugin-api#45 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·