Lumens and Accounts pages obscure the two-reserve cost of pool-share trustlines

Open Beginner friendly
#2,842 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Domain
documentation

Research direction

Start with the Lumens and Accounts pages named in the issue, then compare their trustline wording with the Liquidity Pools page and CAP-0038. Update both general pages so they distinguish one reserve unit for a normal asset trustline from two for a pool-share trustline, linking to the Liquidity Pools explanation. Verify that the exception is visible on both live pages.

Written by the indexing model from the issue text.

Description

raven

[!NOTE]
Automated notice: Stellar Raven filed this issue from its automated evaluation pipeline. The issue includes evidence and a public source record. Please verify the live surface before you act.

Finding

The Lumens and Accounts pages group traditional-asset and pool-share trustlines as account
subentries. Neither page states the important reserve exception. A pool-share trustline counts as
two subentries and requires two base reserves.

The Liquidity Pools page states the two-reserve rule. CAP-0038 defines the same rule. A reader who
uses only the general account pages can treat every trustline as one reserve unit.

This finding is distinct from resolved finding sd-043 in improvements/resolved.json.
That finding removed selling liabilities from the minimum-balance formula.
This finding concerns the subentry multiplier for pool-share trustlines.

Evidence

The four current sources were read on 2026-08-30. The Liquidity Pools page says that a pool-share
trustline requires two base reserves instead of one. CAP-0038 says the entry counts as two
subentries and therefore requires two base reserves.

The Lumens and Accounts pages use broader subentry lists. They do not state this exception beside
their trustline wording. The split makes the general pages incomplete for minimum-balance work.

Additional recorded evidence:

  • 2026-09-08 fresh source reads at stellar/stellar-docs main db501fe9 reproduced the omission. Lumens SHA-256 8f0ce1c60c7bf7d141cdc5807ca9f17ee5666583fb1c9bc87859857edc6df96f and Accounts SHA-256 1ed570951cf7d097ca523eda5483fef95daf53ef17d4d4286f0d867a39b8378a omit the exception. Liquidity Pools SHA-256 26b3d29c162fed0fb9f8c39790bda767554e03b568cf6f6201218b4014517c03 and CAP-0038 SHA-256 febebc612e1dd14006ea677161c626a27575be32b7c937d8aacb30677789c1aa state the two-reserve rule.
  • 2026-08-30 live read of https://developers.stellar.org/docs/learn/fundamentals/lumens grouped traditional-asset and pool-share trustlines as account subentries without naming the pool-share two-reserve exception
  • 2026-08-30 live read of https://developers.stellar.org/docs/learn/fundamentals/stellar-data-structures/accounts grouped traditional-asset and pool-share trustlines as account subentries without naming the pool-share two-reserve exception
  • 2026-08-30 live read of https://developers.stellar.org/docs/learn/fundamentals/liquidity-on-stellar-sdex-liquidity-pools stated that a pool-share trustline requires two base reserves instead of one
  • 2026-08-30 live read of https://github.com/stellar/stellar-protocol/blob/master/core/cap-0038.md stated that a pool-share trustline counts as two subentries and requires two base reserves
  • source case eval/qa/corpus/battery/protocol-core/q-protocol-base-reserve-min-balance.json; its truth.verified entry dated 2026-08-31 names this finding in rootCause (mutual link recorded 2026-08-31)
  • live re-execution 2026-09-04: the Lumens and Accounts pages, both updated 2026-09-02, still group traditional-asset and pool-share trustlines without the two-reserve exception; the Liquidity Pools page and CAP-0038 still state that a pool-share trustline requires two base reserves

Recommendation

Add the pool-share exception beside the trustline item on both general pages. State that a normal
asset trustline adds one reserve unit. State that a pool-share trustline adds two reserve units.

Link the exception to the Liquidity Pools page. Keep the account formula consistent with CAP-0038
and the existing Liquidity Pools explanation.

Source Record

Raven recorded this finding as sd-046 (stellar-docs, discovered 2026-08-30).

Public source record: improvements/stellar-docs/sd-046-pool-share-trustline-reserve-conflict.md

Immutable source snapshot: 8af90c173d8f

Resolution Handoff

When you deploy a fix, link the resolving issue or pull request to the source record.
Then notify Raven through:

https://github.com/stellar-experimental/stellar-raven/issues/new?template=upstream-improvement-ready.yml&title=%5Bupstream-ready%5D%20sd-046%3A%20

Include the finding ID and the resolving issue or pull request.
Include the deployed version or timestamp. Include the smallest live recheck.
Raven verifies the live surface before it sets the finding to fixed-upstream.
An issue closure or merged pull request does not prove the fix.
A separate reviewer repeats the live check before Raven retires the active finding.
Raven keeps a commit-pinned snapshot when one is available.

Dominant language
MDX
Stars
138
Forks
313
Avg merge
3d 11h
Merged PRs (30d)
44

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/stellar-docs

All issues in stellar/stellar-docs

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.