Support adding a new ledger identity to the CLI

Open
#1,883 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
cli

Research direction

Start with the CLI implementation for stellar keys add, comparing the existing --secure-store path with the --ledger-device command proposed here. Trace how key identities and signer configuration are stored, then check the existing --sign-with-ledger flow. Done means a ledger-backed identity can be added through the command and used for signing without storing a secret key.

Written by the indexing model from the issue text.

Description

Currently there is not a way to add a key to the CLI config that uses a ledger device as a signer. There is still a way to sign a tx with the ledger - just pass --sign-with-ledger when signing. Do we also want to add a convenience of allowing a user to add a new key to the config that uses a ledger as a signer?

stellar keys add my-ledger-key --ledger-device

This could be similar to how we have stellar keys add my-key --secure-store which allows for adding a key to the config that has its secret stored in the OS's secure storage.

Dominant language
Rust
Stars
123
Forks
141
Avg merge
2d 21h
Merged PRs (30d)
17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/stellar-cli

All issues in stellar/stellar-cli

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.