Handle dependency version mismatches

Open
#1,378 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
build-system

Research direction

Start with cmd/crates/stellar-ledger/Cargo.toml at the pinned testcontainers dependency, then inspect the soroban-env-host, quote, bollard, and bollard-stubs versions involved. Compare compatible dependency combinations and confirm that the create builds with a tagged testcontainers release instead of the git ref.

Written by the indexing model from the issue text.

Description

In the stellar-ledger create, we are currently pinned to a specific git ref for testcontainers: https://github.com/stellar/stellar-cli/blob/728c79ff839b38d023665fc78daf435479bb2a94/cmd/crates/stellar-ledger/Cargo.toml#L52. It would be nice to have this pointed to an actual tagged release instead.

We currently aren't able to upgrade to testcontainers v0.16.0+ because we have a dependency mismatch between testcontainers and our soroban-env-host crate. As of testcontainers release 0.16.0, it requires the quote crate at version ^1.0.35, but soroban-env-host is using 1.0.33.

To change testcontainers to an older version (e.g. 0.15), we run into mismatches with the version of bollard-stubs that testcontainers uses vs bollard.

Ideas on how to solve this:

  • We could potentially downgrade bollard to a much earlier version, and then use testcontainers v0.15.
  • Upgrade the version of quote used in soroban-env-host
Dominant language
Rust
Stars
123
Forks
141
Avg merge
2d 21h
Merged PRs (30d)
17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/stellar-cli

All issues in stellar/stellar-cli

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.