The argument parsing doesn't check if a value was actually provided
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
Research direction
Locate the shell argument-parsing entry point used by the Docker quickstart command and inspect how options such as --enable consume their following argument. Reproduce the command with --enable --local, then verify that every option requiring a value rejects a missing value and reports an error instead of treating the next option as that value.
Written by the indexing model from the issue text.
Description
The argument parsing doesn't check if a value was actually provided.
For example, if someone runs docker run stellar/quickstart --enable --local, the code will incorrectly set ENABLE to --local instead of catching the missing value.
We could add a check like:
if [[ -z "$1" || "$1" == --* ]]; then
echo "Error: --enable requires a value" >&2
exit 1
fi
The above is an example, but could be applied to other options that accept a parameter.
Originally posted by @Copilot in https://github.com/stellar/quickstart/pull/877#discussion_r2667213722
- Dominant language
- Shell
- Stars
- 222
- Forks
- 236
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 12
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from stellar/quickstart
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
stellar/quickstart#932 · 16 comments · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
stellar/quickstart#923 · 2 comments ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
stellar/quickstart#911 · 2 comments ·
-
feature request
Difficulty 5/5 Over a week Newbie friendliness 35/100
stellar/quickstart#907 · 1 comment ·
-
feature request
Difficulty 5/5 Over a week Newbie friendliness 35/100
stellar/quickstart#906 · 3 comments ·
All issues in stellar/quickstart
Similar issues
-
Update Vish to 1.1.5 Openpackage-update
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oSoWoSo/vOid_Community_repOsitory#144 · 1 comment ·
-
help wanted new command
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
tldr-pages/tldr#24151 ·
-
PacReq: Rune IDE Openpackage request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
pacstall/pacstall-programs#9402 ·
-
[BUG] ci: the first prefetch-images.sh call runs before shard.txt exists, so it is always a no-op Openbug github-actions
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
update-request
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
msys2/MINGW-packages#31768 ·