SEP-24 popup window closes immediately

Open
#9 11 comments 0 reactions 1 assignee View on GitHub

@t0fudev is already working on this.

Since Sep 27, 2024.

Assessment

This issue has not been assessed yet.

Description

bug good first issue ODHack8

When a user clicks the SEP-24 deposit/withdraw buttons on the /dashboard/transfers page, the popup displays for a moment, and immediately closes. I suspect the window is picking up a stream of events in the eventListener part now.

We should add some kind of testing logic that only does popup.close() in the event that the postMessage says something like "transfer initiated" or "successful" or "aborted" or whatever the status messages might be.

Dominant language
Svelte
Stars
20
Forks
33
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/basic-payment-app

All issues in stellar/basic-payment-app

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.