statsmodels / statsmodels/statsmodels
BUG emplike `emplikeAFT.predict` uses endog
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 11.6k
- Forks
- 3.6k
- Avg merge
- 7h 37m
- Merged PRs (30d)
- 96
Description
I don't think this can be right
def predict(self, params, endog=None):
if endog is None:
endog = self.endog
return np.dot(endog, params)
The results class doesn't define predict and doesn't inherit, so I guess it has never been used.
separation between the model class emplikeAFT and the results class AFTResults looks strange.
fitting is params of the results class.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the emplikeAFT.predict method shown in the issue and inspect how emplikeAFT and AFTResults are separated and how fitting supplies parameters. Determine which class should expose prediction and which input it should use; the issue is done when prediction behavior and the model/results boundary are made consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100