statsmodels / statsmodels/statsmodels
GLM aic hasconst
Open
Nobody has claimed this yet.
comp-genmod
type-bug
- Dominant language
- Python
- Stars
- 11.6k
- Forks
- 3.6k
- Avg merge
- 7h 37m
- Merged PRs (30d)
- 96
Description
it looks to me that GLMResults.aic assume hasconst = 1
def aic(self):
return -2 * self.llf + 2*(self.df_model+1)
has hasconst = 0 cleanup ever been extended to GLM ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to GLMResults.aic; start there and trace how df_model and hasconst affect the parameter count. Verify the AIC for GLM fits with and without an intercept, and add or update the relevant GLM test so the corrected behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100