statsmodels / statsmodels/statsmodels
TukeyHSDResults do not keep the pairs tested
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 11.6k
- Forks
- 3.6k
- Avg merge
- 7h 37m
- Merged PRs (30d)
- 96
Description
For the result to be self contained, it should keep the set of pairs used for the testing.
I'm not sure if accessing the pairs through the MultiComparison is correct. If the mc object can change then we would expect the result to keep the original pairs.
Also, it would be nice to use the actual levels instead of using the triu_indices. At least for the report
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the TukeyHSDResults and MultiComparison entry points, then trace how the tested pairs and triu_indices are used in the result and report. The result should retain the original pairs independently of later MultiComparison changes, and the report should use the actual levels; add or update coverage for these behaviors if the surrounding tests identify a location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100