stan-dev / stan-dev/stanc3

Remove SList

Open
#97 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup optimization
Dominant language
OCaml
Stars
160
Forks
59
Avg merge
21h 45m
Merged PRs (30d)
26

Description

We talked a bunch about SList in the meeting the other day and decided to keep it in for now as a lot of optimization code relies on it, but to eventually refactor to get rid of it. We should be able to use regular ocaml lists non-recursively to more explicitly and narrowly define the appropriate level of list nesting (never more than 2 deep, it seems).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SList definition and all usages in the optimization code. Review how those usages represent nested lists before deciding whether regular OCaml lists can replace them. Done means SList is removed and the optimization code continues to work with nesting no deeper than two levels.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.