rename cov_matrix to spd_matrix
Open
@bob-carpenter is already working on this.
Since Oct 3, 2013.
deprecations
feature
- Dominant language
- OCaml
- Stars
- 160
- Forks
- 59
- Avg merge
- 21h 45m
- Merged PRs (30d)
- 26
Description
"spd" is for symmetric positive definite. The problem with "cov_matrix" is that they can be used for precision matrices, too, making the declaration look confusing.
This will also match the functions Marcus has added (but aren't quite yet through the pipe into the Stan language).
We should just deprecate cov_matrix with a warning.
We should also rename the Cholesky factors to match.
(Thanks to Ben for noticing the problem and Marcus for suggesting a better name.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.