stan-dev / stan-dev/stanc3

Investigate function inlining in transformed data block

Open
#1,219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug optimization
Dominant language
OCaml
Stars
160
Forks
59
Avg merge
21h 45m
Merged PRs (30d)
26

Description

The zero-size objects created by function inlining are not properly treated by the data code generation. For now this has lead us to disable the function inliner only for this block (See mitigation in #1218), but we should find a better solution eventually, especially since this may prevent the use of SoA matrices for items constructed in transformed data.

Pinging @SteveBronder on this

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the transformed-data mitigation described in #1218 and trace how function inlining creates zero-size objects in this block. Investigate how data code generation treats those objects and define done as removing the need to disable inlining while allowing SoA matrices for items constructed in transformed data.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.