generalize model_functional and rename to model_functor
Open
Nobody has claimed this yet.
code cleanup
feature
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Description
The model_functional class in src/stan/model/model_funtional.hpp needs to be modified for efficiency and naming consistency.
- rename to
model_functor - add template parameters to the class for the
proptoandjacobianargs
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/stan/model/model_funtional.hpp and inspect the model_functional class and its callers to understand the current naming and argument handling. Done means the class is renamed to model_functor and has template parameters for the propto and jacobian arguments, with affected references updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100