make sure all distributions throw exceptions at undefined boundaries
Open
@seantalts is already working on this.
Since Apr 3, 2017.
code cleanup
documentation
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Description
Go through all the distributions and make sure that they throw exceptions at boundaries. Also change all the doc so it's clear about positive vs. non-negative. For example, scale parameter sigma must be positive for normal distribution and prior count parameters alpha and beta must be positive for beta distribution.
Right now, I think some of the distributions try to be clever, like defining normal(mu,0) to be a discrete distribution with 100% of its mass at mu. Don't!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.