const correctness for services
Open
@mitzimorris is already working on this.
Since Jul 4, 2019.
code cleanup
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Description
Summary:
Two arguments to the service functions (all functions in stan/services/...) should be made constant:
-
io::var_context: this should be easy asvar_contexthas appropriateconstdeclarations -
Model(templated); this will require a lot of fixes as the generated code for our models does not have appropriateconstcorrectness.
It would be nice to have both, but a PR to solve either one on its own would be welcome.
Current Version:
v2.19.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.