stan::mcmc::ps_point protected methods fast_vector_copy_ and fast_matrix_copy_ should be in own file
Open
@mitzimorris is already working on this.
Since Mar 20, 2017.
code cleanup
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Description
Summary:
stan::mcmc:ps_point has two protected methods fast_vector_copy_ and fast_matrix_copy_ used in the copy constructors for this class and its subclasses. These should go in the basic matrix libs rather than in the MCMC directory. And they should have tests if they don't already.
If same functionality elsewhere exists, remove duplication.
Current Version:
v2.14.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.