Rename model_code to program_code, model_name to program_name, etc.
@bob-carpenter is already working on this.
Since Jan 29, 2016.
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Description
From the mailing list:
So when we (in Stan 2.x days) talked about 'parameters {real y;} model
{y ~ normal(0,1);}' as "model code" (which typically was associated with
a model name likeanon_model) we should instead (in Stan 3) refer to
this as "program code" associated with a "program name"?Correct. Any real code is a program. I was very sloppy
with this originally, but Andrew has reformed me :-)For example,
the (Python) signature for the StanProgram constructor (née StanModel)
should beStanProgram(program_code, program_name). If so, is the goal
eventually to have this reflected in the C++ API as well (model_name
occurs in 13 files under the stan tree)?Yes. Feel free to open an issue and assign it to me or
just go in and clean it up yourself in the C++ code (on
a branch named after an issue, of course).
Related protostan issue sakrejda/protostan#32
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.