Remove unused variational::base_family class
Open
@bob-carpenter is already working on this.
Since Nov 19, 2015.
code cleanup
good first issue
- Dominant language
- C++
- Stars
- 2.8k
- Forks
- 388
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 15
Description
The base class variational::base_family has no virtual methods and the one function it does define uses no member variables or functions, so can be made standalone outside of the class. Therefore, base_family should be removed.
- remove
src/stan/variational/base_family.hpp - move function
write_error_msg_()into its own file and rename without suffix_ - patch
families/normal_meanfield.hppandfamilies/normal_fullrank.hpp:- remove references to
base_family - change calls to
write_error_msg_to include and call new function
- remove references to
If the intent was to somehow pull down some of the functionality from the subclasses, then this issue should be repurposed to do that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.