stan-dev / stan-dev/rstantools
Auto-format Stan models during rstan_config()?
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 48
- Forks
- 24
- Avg merge
- 1h 17m
- Merged PRs (30d)
- 1
Description
When running the reverse-dependency checks for rstan 2.31 with the stanc3 branch for erroring on expired deprecations, the majority of dependencies are failing (mostly due to the array syntax).
Rather than requiring another extensive round of patches and submission delays, should we just run the stanc auto-formatter during the rstan_config() call? We can then also be opening issues and contacting the relevant maintainers to say that they should be updating their models, but the actual update could still progress in the interim.
Note that there's still some discussion on when the deprecations should be made into warnings, but it's still worth putting a plan together early.
Tagging the relevant players for input: @hsbadr @jgabry @bgoodri
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the rstan_config() entry point and review how it currently handles Stan models; the issue names no file or test to run. Compare the proposed stanc auto-formatting step with the stanc3 expired-deprecation and array-syntax context. Done requires a maintainer decision on scope and an agreed implementation plan.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100