Why does RStan `import(ggplot2)`?
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 1.1k
- Forks
- 266
- Avg merge
- 2h 56m
- Merged PRs (30d)
- 1
Description
Summary:
RStan's NAMESPACE uses import(ggplot2). Why?
Description:
When I do library(rstan), I attach all of ggplot2's functions to the search path. In my view, this pollutes the search path.
I understand that import(ggplot2) saves on typing and avoid two symbol look-ups, and some advantages regarding generics (see thread).
Still, this seems like a small benefit to the developer with a large cost on the user, who may need to debug name clashes and order of package import.
Why does RStan do import(ggplot2)?
Reproducible Steps:
Not relevant.
Current Output:
Not relevant.
Expected Output:
Not relevant.
RStan Version:
2.18.2
R Version:
R version 3.5.2 (2018-12-20)
Operating System:
OS X 10.14.4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with rstan/rstan/NAMESPACE at the referenced import(ggplot2) line and reproduce the package-loading behavior with library(rstan). Trace where ggplot2 is used and whether the import is required, then determine the expected namespace behavior and verify it after any change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100