stan-dev / stan-dev/rstan

New diagnostic warnings will be confusing until default output is changed

Open
#623 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

@avehtari and I are talking about this at the moment and we think it will be very confusing to users to warn them about the new MCMC diagnostics (e.g, bulk and tail ess)

https://github.com/stan-dev/rstan/blob/e0704f1f4158a26a0a831a85a179a694cd17182d/rstan/rstan/R/check_hmc_diagnostics.R#L86

when these new diagnostics are not yet included in the default output. If we aren't going to wait for the new diagnostics to be the default output before warning users about them then I think we should at least point them in the warning message to the functions that can be used to access these quantities instead of just giving the URL to the Stan warnings document.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read rstan/R/check_hmc_diagnostics.R around line 86 and inspect how the new MCMC diagnostics are currently warned about versus shown in default output. Confirm the intended direction with the discussion, then update the warning or default output so users can find these diagnostics; done means the warning is not confusing and points to their access functions when needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.