stan-dev / stan-dev/rstan

Deprecate plotting functions in RStan or just replace backends?

Open
#517 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

Since we have bayesplot now there's no reason to also maintain all the old ggplot2 code currently in RStan. I guess we can

  • (A) deprecate the existing plotting functions in RStan with a message pointing to the bayesplot

or we can

  • (B) have the current functions in RStan call the bayesplot equivalent directly

Personally I'm in favor of (A) since it simplifies RStan's code base (we'd keep the deprecated functions for quite some time of course, but wouldn't plan to maintain that code in the long term). I'd like to do one or the other soon. What do people think of (A), (B), or some other option I haven't thought of?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by reviewing RStan's existing plotting functions and the corresponding bayesplot equivalents, then resolve whether the project will deprecate the functions or delegate to bayesplot; the work is done when the chosen approach is agreed and implemented.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.