stan-dev / stan-dev/rstan

EBFMI Warnings not shown on serialized stanfits

Open
#438 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

Summary:

When a model has low EBFMI, the warnings are shown after fitting. However, if the model is serialized, and then you try to find a warning via throw_sampler_warnings, EBFMI warnings are not shown.

Description:

The EBFMI warnings are not shown when you call throw_sampler_warnings since
is_sfinstance_valid returns false, apparently because the cached binary is no longer loaded.

Reproducible Steps:

Create model with low BFMI, save using saveRDS, then reload and call
stan:::throw_sampler_warnings(object)

Current Output:

No warning

Expected Output:

BFMI warnings

RStan Version:

2.16.2

R Version:

3.4.1

Operating System:

Ubuntu

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by fitting a low-BFMI model, saving it with saveRDS, reloading it, and calling stan:::throw_sampler_warnings(object). Inspect throw_sampler_warnings and is_sfinstance_valid to understand why the serialized object is rejected. Done means the reloaded object reports the expected BFMI warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.