stan-dev / stan-dev/rstan

validate arguments before compiling model where possible

Open
#355 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

Summary:

See title.

Description:

Came from Stan issue https://github.com/stan-dev/stan/issues/1429:

From jonathanjfshaw on stan-users:

When calling function stan, if arguments warmup > iterations, stan aborts because warmup must be < iterations. But it would be nice to know this before the model is compiled to c, so we don't have to wait until compilation is finished to be reminded we've made an elementary mistake. Validation first?
  • validate as many parameters as possible before calling the C++ compiler
Operating System:

Your operating system (e.g., OS X 10.11.3)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the stan function and the argument checks that currently happen after C++ compilation. Compare parameters such as warmup and iterations with Stan issue #1429; done means validating as many possible arguments before invoking the compiler.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.