stan-dev / stan-dev/rstan

Can we get rid of `permuted=TRUE`?

Open
#345 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

Summary:

The default settings for extract and as.matrix lead to the draws being returned in different orders. This is because permuted defaults to TRUE for extract but as.matrix calls extract internally with permuted=FALSE. Why are we even permuting the draws at all with extract?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the extract and as.matrix entry points and compare their default draw ordering and use of permuted. Done means resolving whether permuted should be removed and defining consistent ordering behavior for both entry points, with the resulting behavior covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.