stan-dev / stan-dev/rstan

Argument validation before model compilation

Open
#157 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

When calling function stan, if arguments warmup > iterations, stan aborts because warmup must be < iterations. But it would be nice to know this before the model is compiled to c, so we don't have to wait until compilation is finished to be reminded we've made an elementary mistake. Validation first?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the R package's stan function, which the issue identifies as the entry point, and inspect when warmup and iterations are checked relative to model compilation. The work is done when invalid values are rejected before C++ compilation begins and the existing validation behavior remains covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.