stan-dev / stan-dev/rstan

spurious warning in pairs.stanfit

Open Beginner friendly
#1,182 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
1.1k
Forks
266
Avg merge
2h 56m
Merged PRs (30d)
1

Description

In pairs.stanfit, on this line we have

usr <- par("usr"); on.exit(par(usr))

this throws a warning (" argument 1 does not name a graphical parameter") ; the on.exit() statement should (I think) be on.exit(par(usr = usr)).

Happy to submit a PR if requested.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in rstan/rstan/R/pairs.R at line 178 and reproduce the warning from pairs.stanfit. Check how the graphics parameters are saved and restored, then verify that the warning no longer appears when the function completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.