stan-dev / stan-dev/posterior

Explicit trainControl blocking parallel rstar

Open
#178 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
R
Stars
171
Forks
26
Avg merge
2d 18h
Merged PRs (30d)
3

Description

I was looking at what would be necessary to add parallelism to the computation of rstar, and thought this would work:

library(doMC)
registerDoMC(4)
rstar(x,uncertainty=T,trControl=caret::trainControl(allowParallel=T))

But I see that the call to caret::train inside rstar defines trControl explicitly itself, blocking the user from toggling parallelism. Was this intentional and is there another way to achieve parallelism?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read R/rstar.R around line 161 and inspect the caret::train call and its explicit trControl. Reproduce the issue with the shown doMC/registerDoMC setup and rstar invocation; done means the requested parallel setting is supported or the alternative behavior is clearly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data, performance
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.