stan-dev / stan-dev/posterior

Improve speed of check_existing_variables when regex=TRUE

Open
#131 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

efficiency
Dominant language
R
Stars
171
Forks
26
Avg merge
2d 18h
Merged PRs (30d)
3

Description

In #130 the speed when regex=FALSE was improved. When regex=TRUE @mjskay suggested:

You might be able to speed up the regex version by translating the input list of regexes into a single regex that matches if any one of them does.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating check_existing_variables and reviewing issue #130 to understand the existing speed improvement for regex=FALSE. Evaluate the regex=TRUE path and the suggested single-regex approach, then verify that matching behavior is preserved while performance improves.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
performance
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.