stan-dev / stan-dev/performance-tests-cmdstan
when fitted model params are not finite, summary stats blow up
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
script runPerformanceTests.py parses output of stansummary (I think),
but param values can look like this:
tau[2] 1.0e+201 nan inf 2.8e+199 2.3e+200 4.5e+201 nan nan nan
and the functions which parse this summary (csv_summary and/or parse_summary) blow up.
use math.isfinite to check values before trying to compute average?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in runPerformanceTests.py and inspect csv_summary and parse_summary, which parse stansummary output and currently fail on non-finite parameter values. Reproduce the shown tau[2] case, then verify that parsing and average computation handle nan and inf without blowing up.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100