align logic for instantiated code
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
Summary:
The mpi_cluster requires instantiated objects. Currently, this code is not handled in an aligned way in comparison to the stan repo. This should be aligned.
Description:
Some code parts of stan-math when using MPI need instantiated code to be linked exactly once for each program. Thus, we need to introduce a libstanmath_mpi.a which we create along the line respective code is handled from the makefiles in the stan repo.
Reproducible Steps:
Please report steps to reproduce the issue. If it's not possible to reproduce, please include a description of how you discovered the issue.
If you have a reproducible example, please include it.
Current Output:
The current output. Knowing what is the current behavior is useful.
Expected Output:
Describe what you expect the output to be. Knowing the correct behavior is also very useful.
Additional Information:
Provide any additional information here.
Current Version:
v2.17.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing how instantiated MPI code is handled in this repository with the corresponding makefile logic in the Stan repository. Identify the existing MPI build path and determine where libstanmath_mpi.a should be created. Done means instantiated code is linked exactly once for each program through the new archive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100