refactor mpi_cluster
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
Summary:
The mpi_cluster resource in stan-math should be revisited and it's design possibly improved.
Description:
The suggested improvements which need consideration are
- better doc for
listening_statemethod for why this returns by reference (or revise directly) - consider Meyers singleton design to handle MPI resource better
- consider use of
lock_guardinstead ofunique_lock(see for a discussion here: http://jakascorner.com/blog/2016/02/lock_guard-and-unique_lock.html)
Reproducible Steps:
NA
Current Output:
The current output. Knowing what is the current behavior is useful.
Expected Output:
Describe what you expect the output to be. Knowing the correct behavior is also very useful.
Additional Information:
Provide any additional information here.
Current Version:
develop
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the mpi_cluster resource and its listening_state method in the Stan Math codebase. Review how listening_state returns by reference and how unique_lock is used, then compare the proposed singleton and lock_guard alternatives; the work is done when the design choice and resulting resource behavior are documented and validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100