Rewrite LDLT code
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
Summary:
The LDLT code is non-idiomatic relative to the Stan code-base. It constructs an object that isn't valid and it's on the caller to verify that it's correct. This leads to more difficult testing and maintenance than necessary.
Description:
I'm finding it very difficult to test behavior of this function. We should rewrite it.
Additional Information:
The code is pretty fast. Whatever we do, we don't want to give up the speed.
Current Version:
v2.12.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the LDLT implementation and the callers that currently verify its result; the issue names no files or tests. Read how the current object is constructed and tested, then define a rewrite that produces a valid object, is easier to test, and preserves the reported speed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100