stan-dev / stan-dev/math

`gaussian_dlm_obs_lpdf` returns NaN instead of rejecting when the innovation variance collapses after time zero

Open
#3,381 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
839
Forks
220
Avg merge
2d 4h
Merged PRs (30d)
14

Description

The vector-V overload checks the innovation variance Q only in the first time step (if (i == 0) check_positive(function, "Q0", Q)). Later time steps compute 1.0 / Q and log(Q) unchecked. A deterministic model whose state covariance collapses after the first update returns NaN silently:

Eigen::MatrixXd y(1, 2);  y << 0.5, 0.5;   // r = 1 variable, T = 2
Eigen::MatrixXd F(1, 1);  F << 1.0;
Eigen::MatrixXd G(1, 1);  G << 1.0;
Eigen::VectorXd V(1);     V << 0.0;         // passes check_nonnegative
Eigen::MatrixXd W(1, 1);  W << 0.0;         // passes check_pos_semidefinite
Eigen::VectorXd m0(1);    m0 << 0.0;
Eigen::MatrixXd C0(1, 1); C0 << 1.0;
double lp = stan::math::gaussian_dlm_obs_lpdf<false>(y, F, G, V, W, m0, C0);
// lp = -nan, no exception

At t = 0, Q = 1 > 0 so the check passes; the update collapses C to zero, so from t = 1 on, Q = 0, Q_inv = inf, and the log density is NaN. The doc comment promises std::domain_error for non-PSD matrices in the Kalman filter.

Environment:
  • Ubuntu 22.04.5 LTS (WSL2, kernel 6.18.33.2-microsoft-standard-WSL2), x86_64
  • stan-dev/math develop @ d20b238b9c
  • g++ 11.4.0 (Ubuntu 22.04), -std=c++17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the vector-V overload of gaussian_dlm_obs_lpdf and its existing tests, tracing how Q is checked after the first time step. Add a regression case based on the deterministic model in the report and verify that the later zero innovation variance raises std::domain_error rather than returning NaN.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.