stan-dev / stan-dev/math

Redundant function `multiply_log` vs. `lmultiply`

Open
#3,318 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
839
Forks
220
Avg merge
2d 4h
Merged PRs (30d)
14

Description

There currently exist two functions multiply_log and lmultiply

They basically do the same thing. IMO they should be consolidated and only one should be kept.

Maybe the other should first get a deprecation warning or something.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the multiply_log and lmultiply entry points and comparing their behavior and usage. Determine which function should remain and whether the other needs deprecation; the work is done when the duplicate API has one clear replacement and the transition is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.