stan-dev / stan-dev/math

Vectorized overloads of `logical_` functions

Open
#3,252 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
C++
Stars
839
Forks
220
Avg merge
2d 4h
Merged PRs (30d)
14

Description

This would be required for https://github.com/stan-dev/stan/issues/3300

We'd like to be able to write things like vector == real and get back and array of ints. The math library functions required:

  • stan::math::logical_eq
  • stan::math::logical_neq
  • stan::math::logical_lt
  • stan::math::logical_lte
  • stan::math::logical_gt
  • stan::math::logical_gte

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing stan::math::logical_eq, logical_neq, logical_lt, logical_lte, logical_gt, and logical_gte implementations and their scalar behavior. Add vectorized coverage for the listed functions so expressions such as vector == real return arrays of ints, then verify the behavior against the requirement linked from stan-dev/stan#3300.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.