stan-dev / stan-dev/math

Missing or misplaced test for GLMS?

Open
#3,152 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
839
Forks
220
Avg merge
2d 4h
Merged PRs (30d)
14

Description

The only GLM lpmf/lpdf test in test/unit/math/prim/prob/ seems to be for binomial_logit_lpdf

The other GLMs apparently only have tests in test/unit/math/rev/prob/

Maybe the files just should be split into two? I am not sure.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the GLM lpmf/lpdf tests under test/unit/math/prim/prob/ and test/unit/math/rev/prob/, noting where binomial_logit_lpdf differs from the other GLMs. Determine whether the files should be split or relocated, then confirm that every affected GLM has its tests in the intended location.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.