Move Eigen.hpp out of prim
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
Description
Right now most files include stan/math/prim/fun/Eigen.hpp before everything else.
#include <stan/math/prim/fun/Eigen.hpp>
#include <stan/math/rev/meta.hpp>
#include <stan/math/rev/core.hpp>
#include <stan/math/rev/fun/value_of.hpp>
But our rules for fwd and rev are the you should always include fwd/rev files before including anything from prim. So we should move Eigen.hpp up to the math folder so it is out of prim.
Current Version:
v4.9.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with stan/math/prim/fun/Eigen.hpp and search the repository for includes of that path and references to the header location. Move the header to the math folder, update affected includes while preserving the fwd/rev ordering rule, and verify that the project builds and its tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100