wiener_lpdf parameter order
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
There are some inconsistencies in the ordering of the parameters in the wiener_lpdf code (see lines 109, 115, 121-122): https://github.com/stan-dev/math/blob/3a080d74172c19f7eb9e7339214bcc4e2847c3bb/stan/math/prim/prob/wiener_lpdf.hpp
It's unclear (and probably unlikely) that this affects the functionality, but is worth noting. In general, the parameters are presented in this order: alpha, tau, beta, delta. But in some cases they are presented in a different order (alpha, beta, tau, delta; see lines 109, 115, 121-122). Ideally the former order should be preserved throughout the code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open stan/math/prim/prob/wiener_lpdf.hpp and inspect the parameter presentations around lines 109, 115, and 121-122. Compare them with the stated alpha, tau, beta, delta order; done means the ordering is consistent throughout the affected code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100